ソースを参照

config: remove legacy DiscoveryConfig

DiscoveryConfig was replaced with the HostFilter, DiscoveryConfig was
not fully ported over when adding host events.
Chris Bannister 9 年 前
コミット
f859eab0b6
3 ファイル変更2 行追加36 行削除
  1. 0 23
      cluster.go
  2. 2 12
      events.go
  3. 0 1
      session.go

+ 0 - 23
cluster.go

@@ -22,27 +22,6 @@ func (p PoolConfig) buildPool(session *Session) *policyConnPool {
 	return newPolicyConnPool(session)
 }
 
-type DiscoveryConfig struct {
-	// If not empty will filter all discovered hosts to a single Data Centre (default: "")
-	DcFilter string
-	// If not empty will filter all discovered hosts to a single Rack (default: "")
-	RackFilter string
-	// ignored
-	Sleep time.Duration
-}
-
-func (d DiscoveryConfig) matchFilter(host *HostInfo) bool {
-	if d.DcFilter != "" && d.DcFilter != host.DataCenter() {
-		return false
-	}
-
-	if d.RackFilter != "" && d.RackFilter != host.Rack() {
-		return false
-	}
-
-	return true
-}
-
 // ClusterConfig is a struct to configure the default cluster implementation
 // of gocoql. It has a variety of attributes that can be used to modify the
 // behavior to fit the most common use cases. Applications that require a
@@ -70,8 +49,6 @@ type ClusterConfig struct {
 	// configuration of host selection and connection selection policies.
 	PoolConfig PoolConfig
 
-	Discovery DiscoveryConfig
-
 	// If not zero, gocql attempt to reconnect known DOWN nodes in every ReconnectSleep.
 	ReconnectInterval time.Duration
 

+ 2 - 12
events.go

@@ -192,12 +192,7 @@ func (s *Session) handleNewNode(host net.IP, port int, waitForBinary bool) {
 		hostInfo.setPeer(addr)
 	}
 
-	if s.cfg.HostFilter != nil {
-		if !s.cfg.HostFilter.Accept(hostInfo) {
-			return
-		}
-	} else if !s.cfg.Discovery.matchFilter(hostInfo) {
-		// TODO: remove this when the host selection policy is more sophisticated
+	if s.cfg.HostFilter != nil && !s.cfg.HostFilter.Accept(hostInfo) {
 		return
 	}
 
@@ -254,12 +249,7 @@ func (s *Session) handleNodeUp(ip net.IP, port int, waitForBinary bool) {
 			host.setPeer(addr)
 		}
 
-		if s.cfg.HostFilter != nil {
-			if !s.cfg.HostFilter.Accept(host) {
-				return
-			}
-		} else if !s.cfg.Discovery.matchFilter(host) {
-			// TODO: remove this when the host selection policy is more sophisticated
+		if s.cfg.HostFilter != nil && !s.cfg.HostFilter.Accept(host) {
 			return
 		}
 

+ 0 - 1
session.go

@@ -145,7 +145,6 @@ func NewSession(cfg ClusterConfig) (*Session, error) {
 	}
 
 	var hosts []*HostInfo
-
 	if !cfg.disableControlConn {
 		s.control = createControlConn(s)
 		if err := s.control.connect(cfg.Hosts); err != nil {