Quellcode durchsuchen

remove the useless Shutdown() method

Jackson Tian vor 7 Jahren
Ursprung
Commit
7f62c725fd

+ 0 - 1
sdk/auth/signer.go

@@ -32,7 +32,6 @@ type Signer interface {
 	GetAccessKeyId() (string, error)
 	GetExtraParam() map[string]string
 	Sign(stringToSign, secretSuffix string) string
-	Shutdown()
 }
 
 func NewSignerWithCredential(credential Credential, commonApi func(request *requests.CommonRequest, signer interface{}) (response *responses.CommonResponse, err error)) (signer Signer, err error) {

+ 0 - 4
sdk/auth/signers/signer_access_key.go

@@ -52,7 +52,3 @@ func (signer *AccessKeySigner) Sign(stringToSign, secretSuffix string) string {
 	secret := signer.credential.AccessKeySecret + secretSuffix
 	return ShaHmac1(stringToSign, secret)
 }
-
-func (signer *AccessKeySigner) Shutdown() {
-
-}

+ 0 - 2
sdk/auth/signers/signer_access_key_test.go

@@ -19,6 +19,4 @@ func TestSignerAccessKey(t *testing.T) {
 	assert.Nil(t, err)
 	assert.Equal(t, "accessKeyId", accessKeyId)
 	assert.Equal(t, "Dqy7QZhP4TyQUDa3SBSFXopJaIo=", s.Sign("string to sign", "suffix"))
-	// nothing
-	s.Shutdown()
 }

+ 0 - 4
sdk/auth/signers/signer_ecs_ram_role.go

@@ -165,7 +165,3 @@ func (signer *EcsRamRoleSigner) refreshCredential(response *responses.CommonResp
 func (signer *EcsRamRoleSigner) GetSessionCredential() *SessionCredential {
 	return signer.sessionCredential
 }
-
-func (signer *EcsRamRoleSigner) Shutdown() {
-
-}

+ 0 - 2
sdk/auth/signers/signer_ecs_ram_role_test.go

@@ -19,8 +19,6 @@ func Test_ECSRamRole(t *testing.T) {
 	assert.Equal(t, "HMAC-SHA1", singer.GetName())
 	assert.Equal(t, "", singer.GetType())
 	assert.Equal(t, "1.0", singer.GetVersion())
-	// nothing
-	singer.Shutdown()
 }
 
 func Test_EcsRamRoleSigner_buildCommonRequest(t *testing.T) {

+ 0 - 4
sdk/auth/signers/signer_key_pair.go

@@ -145,7 +145,3 @@ func (signer *SignerKeyPair) refreshCredential(response *responses.CommonRespons
 	}
 	return
 }
-
-func (signer *SignerKeyPair) Shutdown() {
-
-}

+ 0 - 2
sdk/auth/signers/signer_key_pair_test.go

@@ -37,8 +37,6 @@ func TestKeyPairOk(t *testing.T) {
 	assert.Equal(t, "1.0", s.GetVersion())
 	assert.Equal(t, "", s.GetType())
 	assert.Len(t, s.GetExtraParam(), 0)
-	// nothing
-	s.Shutdown()
 }
 
 func Test_buildCommonRequest(t *testing.T) {

+ 0 - 4
sdk/auth/signers/signer_ram_role_arn.go

@@ -170,7 +170,3 @@ func (signer *RamRoleArnSigner) refreshCredential(response *responses.CommonResp
 func (signer *RamRoleArnSigner) GetSessionCredential() *SessionCredential {
 	return signer.sessionCredential
 }
-
-func (signer *RamRoleArnSigner) Shutdown() {
-
-}

+ 0 - 2
sdk/auth/signers/signer_ram_role_arn_test.go

@@ -36,8 +36,6 @@ func Test_NewRamRoleArnSigner(t *testing.T) {
 	signer, err = NewRamRoleArnSigner(c, nil)
 	assert.NotNil(t, err)
 	assert.Equal(t, "[SDK.InvalidParam] Assume Role session duration should be in the range of 15min - 1Hr", err.Error())
-	// nothing
-	signer.Shutdown()
 }
 
 func Test_RamRoleArn_buildCommonRequest(t *testing.T) {

+ 0 - 4
sdk/auth/signers/signer_sts_token.go

@@ -52,7 +52,3 @@ func (signer *StsTokenSigner) Sign(stringToSign, secretSuffix string) string {
 	secret := signer.credential.AccessKeySecret + secretSuffix
 	return ShaHmac1(stringToSign, secret)
 }
-
-func (signer *StsTokenSigner) Shutdown() {
-
-}

+ 0 - 2
sdk/auth/signers/signer_sts_token_test.go

@@ -23,6 +23,4 @@ func TestSignerSTSToken(t *testing.T) {
 	assert.Len(t, params, 1)
 	assert.Equal(t, "token", params["SecurityToken"])
 	assert.Equal(t, "Dqy7QZhP4TyQUDa3SBSFXopJaIo=", s.Sign("string to sign", "suffix"))
-	// nothing
-	s.Shutdown()
 }

+ 0 - 4
sdk/auth/signers/signer_v2.go

@@ -52,7 +52,3 @@ func (signer *SignerV2) Sign(stringToSign, secretSuffix string) string {
 	secret := signer.credential.PrivateKey
 	return Sha256WithRsa(stringToSign, secret)
 }
-
-func (signer *SignerV2) Shutdown() {
-
-}

+ 0 - 2
sdk/auth/signers/signer_v2_test.go

@@ -33,6 +33,4 @@ vftlY0Hs1vNXcaBgEA==`
 	assert.Nil(t, err)
 	assert.Equal(t, "publicKeyId", accesskeyId)
 	assert.Equal(t, "KoQz1EdAD5jsmYuvaDZTQLQo4bP2ex6zR0dJcsNTjVE/MgGP8emz0rhiwSDmffEsbGPrRN8qPWGltEleH7xbLuBtviBbW5M7Ga7cuYQaxATDbwsPVNGgr3QPWY+nEjX3lBwGAeebf5H9WidI1cbTB+uYh0XB4o/sL34npE6qOxk=", s.Sign("string to sign", "suffix"))
-	// nothing
-	s.Shutdown()
 }

+ 0 - 1
sdk/client.go

@@ -372,7 +372,6 @@ func (client *Client) ProcessCommonRequestWithSigner(request *requests.CommonReq
 }
 
 func (client *Client) Shutdown() {
-	client.signer.Shutdown()
 	// lock the addAsync()
 	client.asyncChanLock.Lock()
 	defer client.asyncChanLock.Unlock()